Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in {bash,zsh}_completions.go #1459

Merged
merged 2 commits into from
Dec 7, 2021
Merged

fix: typo in {bash,zsh}_completions.go #1459

merged 2 commits into from
Dec 7, 2021

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Jul 18, 2021

subDir seems to be a typo. It is deep inside bash_completions.go used to generate bash completion scripts. I am not sure how to write a test for this.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

Thanks @favonia!
Could you please also fix the same problem in zsh_completions.go?

I think writing a test would be more complicated then it's value, so I think the fix itself is sufficient.

@favonia favonia changed the title Fix typo in bash_completions.go Fix typo in {bash,zsh}_completions.go Jul 19, 2021
@favonia favonia changed the title Fix typo in {bash,zsh}_completions.go Fix a typo in {bash,zsh}_completions.go Jul 19, 2021
@favonia
Copy link
Contributor Author

favonia commented Jul 19, 2021

Done!

marckhouzam
marckhouzam approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@favonia favonia changed the title Fix a typo in {bash,zsh}_completions.go fix: typo in {bash,zsh}_completions.go Aug 7, 2021
@marckhouzam marckhouzam mentioned this pull request Sep 25, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This PR is being marked as stale due to a long period of inactivity

stmcginnis
stmcginnis approved these changes Nov 2, 2021
View reviewed changes
Copy link

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 5, 2021
@favonia @umarcor
Fix typo in bash_completions.go and zsh_completions.go (spf13#1459)
58c97f6
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 15, 2021
@favonia @umarcor
Fix typo in bash_completions.go and zsh_completions.go (spf13#1459)
bce0b5c
umarcor pushed a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
@favonia @umarcor
Fix typo in bash_completions.go and zsh_completions.go (spf13#1459)
cee3bca
@jpmcb jpmcb merged commit c7a4421 into spf13:master Dec 7, 2021
@jpmcb jpmcb added this to the 1.3.0 milestone Dec 7, 2021
@jpmcb jpmcb removed the kind/stale label Dec 7, 2021
@favonia favonia deleted the patch-1 branch December 9, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

@stmcginnis stmcginnis stmcginnis approved these changes

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@favonia @CLAassistant @marckhouzam @stmcginnis @jpmcb